feat: File browsers - add ability to quickly jump to any path segment #1659
Conversation
|
@meteyou as per your request:
I've changed the "house icon" to "/gcodes" string in the "G-code files" explorer. However, I've left a default slot with the said icon, in case if the first segment has no directory name. If you don't think this is necessary, this can of course be removed. |
Signed-off-by: Michał Dziekoński <[email protected]>
Signed-off-by: Michał Dziekoński <[email protected]>
mdziekon
force-pushed
the
feature/file-browser-quick-path-nav
branch
from
cc1af28 to
b2f89cd
Compare
|
@mdziekon thx for your commit. In moonraker, every path has a root directory. examples for these are:
Its not possible, that there are files in / directly. So i think it should fit with these root directories as first option in the "breadcrumbs". |
Signed-off-by: Michał Dziekoński <[email protected]>
Signed-off-by: Michał Dziekoński <[email protected]>
|
@meteyou I've assumed that your reply means "yes, please delete redundant code", and so I did exactly that (and added some documentation). This PR should be ready for (another?) review. |
|
@mdziekon THX! I will review it as soon as possible. |
There was a problem hiding this comment.
I just took a closer look at the PR. I commented a question for you above. I also noticed that this function still needs to be added in timelapse. I also have another question. Could you make the current folder "unclickable"? Currently, the hover has the underline and the pointer. It looks weird when you can click, but nothing happens.
I think i can merge this PR after these "fixes"
Signed-off-by: Michał Dziekoński <[email protected]>
Signed-off-by: Michał Dziekoński <[email protected]>
Signed-off-by: Michał Dziekoński <[email protected]>
Signed-off-by: Michał Dziekoński <[email protected]>
|
Thx for your PR! |
Description
This PR adds the feature requested in #1643, which allows to interactively use the "current path" (visible above the file browsers / explorer, eg. "GCode files" explorer) to quickly navigate to any segment of the path.
Path navigations allows for both mouse & keyboard usage (provides bare minimum of accessibility), allows to select the entire path (eg. to copy & paste it as text somewhere). It is also implemented as a reusable component, to both help with maintainability, and allow for future reuse in other places.
Related Tickets & Documents
#1643
Mobile & Desktop Screenshots/Recordings
Gcode files explorer (webm)
Config files explorer (webm)
[optional] Are there any post-deployment tasks we need to perform?
N/A